I'm glad they did. There are many sites that share or sell that information. I wouldn't want them getting my email address because they signed up via Facebook. One of the big things I promote about any Elgg site I create, no tracking, no ads, personal information isn't required and information is never sold or shared.
I am using elgg 1.11.1 an can't find this line
add_to_river('river/annotation/generic_comment/create', 'comment', $user->guid, $entity->guid, "", 0, $annotation);
instead i find
// Add to river
'view' => 'river/object/comment/create',
'action_type' => 'comment',
'subject_guid' => $user->guid,
'object_guid' => $guid,
'target_guid' => $entity_guid,
Shall I delete this one?
add_to_river() was deprecated by elgg_create_river_item(). So, deletion of the elgg_create_river_item() call seems the correct way. But I don't know if this will be the only step you have to do to reach your goal as there might be other changes in newer Elgg version not considered in the (outdated) instructions you are referring to.